Open
Conversation
Author
|
I checked the failing tests and, from what I can tell, they appear to be preexisting rather than introduced by this PR. I also see similar failures on the current main branch. Locally, the issue from #995 is fixed by this change: the original reproduction now succeeds, and I also reran Pkg.test() to compare against the baseline behavior. If helpful, I can try to isolate whether any of the current CI failures are actually specific to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
When p === nothing, tunables becomes SciMLBase.NullParameters().
allocate_vjp(::SciMLBase.NullParameters) previously returned NullParameters(), which caused SavingIntegrandSumAffect(..., ::NullParameters, ::Nothing) to be constructed inside IntegratingSumCallback, producing a MethodError. Returning nothing instead ensures the callback prototype/cache types match and restores correct behavior. This change fixes Zygote.gradient(loss2, nothing) while leaving the existing test suite results unchanged.