Open
Conversation
…of p === nothing: Use an empty tunables container instead of nothing to avoid length/Functors errors, while preserving repack = _ -> nothing. Enables Zygote.gradient(loss2, nothing) to return (nothing,).]
| # minimal fix 4 for #995 | ||
| #--------------------------------------------------- | ||
| if p === nothing | ||
| tunables = Float64[] # 0-length, Functors-safe |
Member
There was a problem hiding this comment.
this isn't necessarily typed correctly, and would result in doing unnecessary computations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a failure in GaussAdjoint when p === nothing.
Previously, the GaussAdjoint path assumed tunables supports length and Functors traversal. When p === nothing, this resulted in errors (e.g. length(::Nothing) or recursive traversal failures), causing Zygote.gradient(..., nothing) to error.
The fix represents the no-parameter case using an empty tunables container (Float64[]) while preserving repack = _ -> nothing to maintain RHS semantics. This allows Zygote.gradient(..., nothing) to correctly return (nothing,), consistent with InterpolatingAdjoint.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Testing:
Docs:
No documentation updates were required (internal fix; no public API changes).
I have not yet added a dedicated regression test; I can add one if you can point me to the preferred test location/pattern for SciMLSensitivity.