This repository was archived by the owner on Jul 13, 2025. It is now read-only.
test: add unit test for checking error response without code#684
Open
nguyentoanit wants to merge 2 commits intomasterfrom
Open
test: add unit test for checking error response without code#684nguyentoanit wants to merge 2 commits intomasterfrom
nguyentoanit wants to merge 2 commits intomasterfrom
Conversation
Contributor
|
I think I am not understanding the intent here. Feels like we are maybe putting too much faith into Amazon returning correct headers and data. I've seen on the SP API where they return an error with 200 status. :) Ping me on Slack when you have a minute, let's go over this live. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.