Skip to content

feat(sort, flat-table-header): add additional aria support and general accessibility improvements#7766

Open
edleeks87 wants to merge 1 commit intomasterfrom
sort-improvements
Open

feat(sort, flat-table-header): add additional aria support and general accessibility improvements#7766
edleeks87 wants to merge 1 commit intomasterfrom
sort-improvements

Conversation

@edleeks87
Copy link
Contributor

@edleeks87 edleeks87 commented Feb 11, 2026 •
edited
Loading

Proposed behaviour

Sort:

  • Replaces Typography component with a display: none span.
  • Replaces aria-labelledby with aria-describedby.
  • Adds aria-roledescription and translation override support

FlatTableHeader:

  • Adds aria-sort and computes value based on state of Sort rendered within it.

Current behaviour

Typography component used
aria-labelledby set on Sort
No aria-roledescription attribute on Sort
No aria-sort on FlatTableHeader

Checklist

  • Commits follow our style guide
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

@edleeks87 edleeks87 self-assigned this Feb 11, 2026
@edleeks87 edleeks87 changed the title feat(sort, flat-table-header): add additional aria support and genera… feat(sort, flat-table-header): add additional aria support and general accessibility improvements Feb 11, 2026
@edleeks87 edleeks87 force-pushed the sort-improvements branch 2 times, most recently from c4f79b6 to e7dffa8 Compare February 11, 2026 09:33
@edleeks87 edleeks87 marked this pull request as ready for review February 11, 2026 09:45
@edleeks87 edleeks87 requested review from a team as code owners February 11, 2026 09:45
@edleeks87 edleeks87 marked this pull request as draft February 12, 2026 15:01
@edleeks87 edleeks87 marked this pull request as ready for review February 13, 2026 07:46
@edleeks87 edleeks87 marked this pull request as draft February 13, 2026 07:46
@edleeks87 edleeks87 marked this pull request as ready for review February 13, 2026 07:48
@edleeks87
feat(sort, flat-table-header): add additional aria support and genera…
9bec56c 
…l accessibility improvements

Sort:
- Replaces `Typography` component with a `display: none` `span`.
- Replaces `aria-labelledby` with `aria-describedby`.
- Adds `aria-roledescription` and translation override support

FlatTableHeader:
- Adds `aria-sort` and computes value based on state of `Sort` rendered within it.

Box:
- Adds `aria-live` support.

Typography:
- Adds `aria-live` support.
- Adds `role` prop with `status` or `alert` values to improve live region support.
@edleeks87 edleeks87 marked this pull request as draft February 13, 2026 11:00
@DipperTheDan DipperTheDan self-requested a review February 13, 2026 11:44
@edleeks87 edleeks87 marked this pull request as ready for review February 13, 2026 12:55
@Fenwick17
Copy link

Fenwick17 commented Feb 13, 2026

Tested on our end and all good here.

@edleeks87 edleeks87 added Passed a11y Review and removed Pending UX QA Work in progress This is a WIP PR so may not be ready for review labels Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DipperTheDan DipperTheDan DipperTheDan approved these changes

@nineteen88 nineteen88 nineteen88 approved these changes

Assignees

@edleeks87 edleeks87

Labels

Passed a11y Review Passed Review Pending QA Squad Front End

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@edleeks87 @Fenwick17 @DipperTheDan @nineteen88