Fix/53 VLA allocation #58
Open
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
- Replace the returned value by STSE_SERVICE_BUFFER_OVERFLOW.
- For stsafe-a length check, maybe we could use tsafea_maximum_command_length array. By the way, no need to define platform buffer length through MW.
if (received_length>= stsafea_maximum_command_length[pSTSE->device_type]) {
return STSE_SERVICE_BUFFER_OVERFLOW;
}
Contributor
There was a problem hiding this comment.
Same as previous comment but adapt to stsafe-l
nils-cercariolo-st
force-pushed
the
fix/53_vla_allocation
branch
from
fd0ee3b to
2f86902
Compare
Contributor
Author
|
Great points, thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a I2C buffer size definition in conf file which allows to check the received length in case of corruption since CRC isn't checked yet at this time