TEMP: change requirements to test stf PR#8483
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the requirements.txt to use a personal fork for the sssd-test-framework dependency. The pull request title, 'TEMP: change requirements to test stf PR', strongly suggests this is a temporary change for testing purposes. Merging such changes into a main branch is a critical issue, as it introduces dependencies on non-standard, personal repositories, which poses a security and maintenance risk. This pull request should not be merged in its current state.
| #git+https://github.com/SSSD/sssd-test-framework | ||
| git+https://github.com/spoore1/sssd-test-framework@gdm_and_topo_fixes_v2 |
There was a problem hiding this comment.
This change introduces a dependency on a personal fork, and the PR title indicates it is temporary. Merging dependencies from personal forks into a main branch is a critical issue as it can introduce instability, security vulnerabilities, and maintenance problems. This change should be reverted before merging. If this PR is only for temporary testing, it should be closed without merging.
git+https://github.com/SSSD/sssd-test-framework
spoore1
force-pushed
the
test_gdm_updates
branch
from
c85a684 to
02eca17
Compare
|
Closing since the PR tested is now merged. |
1 participant
No description provided.