Tests: Add integration tests validating SSSD socket#8481
Tests: Add integration tests validating SSSD socket#8481aborah-sudo wants to merge 1 commit intoSSSD:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new suite of integration tests for SSSD's socket activation feature. The tests validate the lifecycle of individual socket-activated responders and also cover scenarios with a mix of socket-activated and traditional services. The implementation is generally good, but I've identified a high-severity issue in one of the tests where a necessary service restart is missing after configuration changes. This could make the test unreliable. My review includes a specific suggestion to fix this.
aborah-sudo
force-pushed
the
socket
branch
4 times, most recently
from
d5b5bb0 to
35acf9d
Compare
jakub-vavra-cz
left a comment
jakub-vavra-cz
left a comment
There was a problem hiding this comment.
The code looks pretty nice however we need to separate the autofs cases to standalone ones with autofs in the test name. Autofs is not supported in image mode so we are skipping those tests based on name (see: https://gitlab.cee.redhat.com/sssd/sssd-qe/-/blob/main/test-plan/mh_jobs.yaml#L39) and we would be unable to do that here.
The tests that are not using autofs could be probably switched to topology BareLDAP that do not need nfs and kcm so they could be run on smaller footprint.
Add integration tests validating SSSD socket activation behavior for individual responders and mixed socket/traditional configurations.
3 participants
Add integration tests validating SSSD socket activation behavior for individual responders and mixed socket/traditional configurations.