memberOf plugin: swap instead of a shift

alexey-tikhonov · alexey-tikhonov · commit e35eab49e1fc · 2026-02-25T18:53:49.000+01:00
when removing a duplicate. DNs order doesn't matter.
diff --git a/src/ldb_modules/memberof.c b/src/ldb_modules/memberof.c
@@ -825,9 +825,7 @@ static int mbof_add_operation(struct mbof_add_operation *addop)
             }
             if (j < parents->num) {
                 /* remove duplicate */
-                for (;j+1 < parents->num; j++) {
-                    parents->dns[j] = parents->dns[j+1];
-                }
+                parents->dns[j] = parents->dns[parents->num - 1];
                 parents->num--;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -825,9 +825,7 @@ static int mbof_add_operation(struct mbof_add_operation *addop)`
`825`	`825`	`}`
`826`	`826`	`if (j < parents->num) {`
`827`	`827`	`/* remove duplicate */`
`828`		`- for (;j+1 < parents->num; j++) {`
`829`		`- parents->dns[j] = parents->dns[j+1];`
`830`		`- }`
	`828`	`+ parents->dns[j] = parents->dns[parents->num - 1];`
`831`	`829`	`parents->num--;`
`832`	`830`	`}`
`833`	`831`	`}`