memberOf plugin: redundant comparison removed

alexey-tikhonov · alexey-tikhonov · commit 2467b8605c00 · 2026-02-25T18:53:49.000+01:00
'msg-&gt;dn' (== 'addop-&gt;entry_dn') is already filtered out from 'parents-&gt;dns[i]'
at the beginning of `mbof_add_operation()`
diff --git a/src/ldb_modules/memberof.c b/src/ldb_modules/memberof.c
@@ -934,7 +934,6 @@ static int mbof_add_operation(struct mbof_add_operation *addop)
         return LDB_ERR_OPERATIONS_ERROR;
     }
     for (i = 0, j = 0; i < parents->num; i++) {
-        if (ldb_dn_compare(parents->dns[i], msg->dn) == 0) continue;
         val = ldb_dn_get_linearized(parents->dns[i]);
         el->values[j].length = strlen(val);
         el->values[j].data = (uint8_t *)talloc_strdup(el->values, val);

Original file line number	Diff line number	Diff line change
`@@ -934,7 +934,6 @@ static int mbof_add_operation(struct mbof_add_operation *addop)`
`934`	`934`	`return LDB_ERR_OPERATIONS_ERROR;`
`935`	`935`	`}`
`936`	`936`	`for (i = 0, j = 0; i < parents->num; i++) {`
`937`		`- if (ldb_dn_compare(parents->dns[i], msg->dn) == 0) continue;`
`938`	`937`	`val = ldb_dn_get_linearized(parents->dns[i]);`
`939`	`938`	`el->values[j].length = strlen(val);`
`940`	`939`	`el->values[j].data = (uint8_t *)talloc_strdup(el->values, val);`