Draft
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| SecurityProfileOptions.RetainUIDs; | ||
| if (CustomSecurityProfile != null) | ||
| { | ||
| profile = SecurityProfile.LoadProfile(new StringReader(CustomSecurityProfile), flags); |
Check warning
Code scanning / CodeQL
Missing Dispose call on local IDisposable Warning
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 12 months ago
To fix the issue, the StringReader instance should be properly disposed of. The best approach is to wrap its creation and usage in a using block. This ensures that the Dispose method is called automatically, even if an exception occurs. The using block should encompass the call to SecurityProfile.LoadProfile to ensure the StringReader is disposed of immediately after its use.
Suggested changeset
1
Rdmp.Dicom/Extraction/FoDicomBased/FoDicomAnonymiser.cs
| @@ -300,3 +300,6 @@ | ||
| { | ||
| profile = SecurityProfile.LoadProfile(new StringReader(CustomSecurityProfile), flags); | ||
| using (var stringReader = new StringReader(CustomSecurityProfile)) | ||
| { | ||
| profile = SecurityProfile.LoadProfile(stringReader, flags); | ||
| } | ||
| } |
Copilot is powered by AI and may make mistakes. Always verify output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.