feat: cache binaries for released versions accros workflow runs#342
Open
manjunathSurendrakumar wants to merge 3 commits intomainfrom
Open
feat: cache binaries for released versions accros workflow runs#342manjunathSurendrakumar wants to merge 3 commits intomainfrom
manjunathSurendrakumar wants to merge 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Changes:
src/download.ts:
✅ Added cacheFile and find imports
✅ Modified downloadPiperBinary() to check cache first
✅ Added caching after download
✅ Maintained backward compatibility
src/github.ts:
✅ Added cacheFile and find imports
✅ Modified buildPiperFromSource() to check cache first
✅ Added caching after build
✅ Removed TODO comments
✅ Added cleanup of temp directories
src/build.ts:
✅ Added cacheFile and find imports
✅ Modified buildPiperInnerSource() to check cache first
✅ Added caching after build
✅ Added cleanup of temp directories
Test Files Updated:
✅ test/github.test.ts
✅ Updated 4 existing tests to mock toolCache.find()