Conversation
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Markus1812
left a comment
There was a problem hiding this comment.
Hi, thanks for contributing your object type. Please take a look at the comments below. If you agree with the suggestion, you can directly apply them here in GitHub and generate the new schema afterwards via your ABAP system.
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
This comment was marked as outdated.
This comment was marked as outdated.
Markus1812
left a comment
There was a problem hiding this comment.
Hi, sorry for the delay. While reviewing again, I have some further questions.
| "! <p class="shorttext">Header</p> | ||
| "! Header | ||
| "! $required | ||
| header TYPE zif_aff_types_v1=>ty_header_60, |
There was a problem hiding this comment.
Just to verify: Which ABAP Language types does your object type support? Cloud + Key User + Standard?
There was a problem hiding this comment.
As of today (2605), only Standard is supported.
We want to enable it for Cloud now, and plan to enable it for Key-Users in the future as well.
There was a problem hiding this comment.
Ok, ty_header_60 contains an enum for the ABAP language version that includes Standard, Cloud and Key User. If you plan to support Key Users in the same release as well, this is fine. Otherwise, there is ty_header_60_cloud which only contains Standard + Cloud. Then this can be changed at a later point in time, which should be a compatible change.
| "! <p class="shorttext">JSON Definition</p> | ||
| "! JSON Definition | ||
| BEGIN OF ty_json_definition, | ||
| "! <p class="shorttext">JSON Content</p> | ||
| "! JSON Content | ||
| "! $required | ||
| json_content TYPE string, | ||
| END OF ty_json_definition. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
One further question: Do you plan to build & ship a server-driven editor or do you only want to implement the AFF as transport object? |
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Both Server-Driven Editor and AFF-Transport are relevant for us. |
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
|
@Markus1812
|
No description provided.