Skip to content

[ABIQ] Add new object type ABIQ#745

Open
LutzR-SAP wants to merge 45 commits intoSAP:mainfrom
LutzR-SAP:aibq/new-aff
Open

[ABIQ] Add new object type ABIQ#745
LutzR-SAP wants to merge 45 commits intoSAP:mainfrom
LutzR-SAP:aibq/new-aff

Conversation

@LutzR-SAP
Copy link

No description provided.

@cla-assistant
Copy link

cla-assistant bot commented Mar 17, 2026

CLA assistant check
All committers have signed the CLA.

LutzR-SAP and others added 10 commits March 17, 2026 17:45
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Markus1812

This comment was marked as outdated.

Copy link
Member

@Markus1812 Markus1812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for contributing your object type. Please take a look at the comments below. If you agree with the suggestion, you can directly apply them here in GitHub and generate the new schema afterwards via your ABAP system.

LutzR-SAP and others added 16 commits March 19, 2026 08:30
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
LutzR-SAP and others added 7 commits March 19, 2026 08:32
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
@LutzR-SAP LutzR-SAP requested a review from Markus1812 March 19, 2026 07:57
@LutzR-SAP

This comment was marked as outdated.

Copy link
Member

@Markus1812 Markus1812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry for the delay. While reviewing again, I have some further questions.

"! <p class="shorttext">Header</p>
"! Header
"! $required
header TYPE zif_aff_types_v1=>ty_header_60,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to verify: Which ABAP Language types does your object type support? Cloud + Key User + Standard?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of today (2605), only Standard is supported.
We want to enable it for Cloud now, and plan to enable it for Key-Users in the future as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, ty_header_60 contains an enum for the ABAP language version that includes Standard, Cloud and Key User. If you plan to support Key Users in the same release as well, this is fine. Otherwise, there is ty_header_60_cloud which only contains Standard + Cloud. Then this can be changed at a later point in time, which should be a compatible change.

Comment on lines +100 to +107
"! <p class="shorttext">JSON Definition</p>
"! JSON Definition
BEGIN OF ty_json_definition,
"! <p class="shorttext">JSON Content</p>
"! JSON Content
"! $required
json_content TYPE string,
END OF ty_json_definition.

This comment was marked as resolved.

@Markus1812
Copy link
Member

One further question: Do you plan to build & ship a server-driven editor or do you only want to implement the AFF as transport object?

LutzR-SAP and others added 7 commits March 25, 2026 09:15
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: Markus <markus@markuswambach.de>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@LutzR-SAP
Copy link
Author

One further question: Do you plan to build & ship a server-driven editor or do you only want to implement the AFF as transport object?

Both Server-Driven Editor and AFF-Transport are relevant for us.

LutzR-SAP and others added 4 commits March 25, 2026 09:27
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@LutzR-SAP
Copy link
Author

@Markus1812
Have you seen my comment, regarding the "json_content"?

The JSON needs to confirm to a pre-existing JSON-Schema. The Schema itself is available in the ABAP system. Unfortunately, this JSON Schema cannot be described with an ABAP structure (contains e.g. recursive type-definitions). Can such a schema be used/referred to in AFF-Definitions? quick-action.schema.json

@LutzR-SAP LutzR-SAP requested a review from Markus1812 March 25, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants