Skip to content

AFF for Lock Objects (ENQU)#737

Open
anne-hobbs wants to merge 54 commits intoSAP:mainfrom
anne-hobbs:main
Open

AFF for Lock Objects (ENQU)#737
anne-hobbs wants to merge 54 commits intoSAP:mainfrom
anne-hobbs:main

Conversation

@anne-hobbs
Copy link

No description provided.

@cla-assistant
Copy link

cla-assistant bot commented Feb 3, 2026

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Feb 3, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@albertmink albertmink added the new-object This is a new object type added to AFF label Feb 3, 2026
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anne-hobbs for your contribution. 👍

In a first iteration I went only over the example file and added some suggestions/ideas/questions there.

anne-hobbs and others added 20 commits February 25, 2026 09:59
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Michael Schneider <micha.schneider@sap.com>
Co-authored-by: Michael Schneider <micha.schneider@sap.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@uenal-akkaya
Copy link
Contributor

uenal-akkaya commented Mar 7, 2026

The lock mode in primaryTable -> lockMode can also be empty, so that nothing is selected. This should be also reflected in the AFF.

This does not apply to secondaryTables->lockMode.
Edit: The empty value can also be specified for secondaryTables->lockMode

@anne-hobbs
Copy link
Author

anne-hobbs commented Mar 16, 2026

The lock mode in primaryTable -> lockMode can also be empty, so that nothing is selected. This should be also reflected in the AFF.

This does not apply to secondaryTables->lockMode.

ENQU can be active with initial lock mode -> how do we reflect this in AFF?
Secondary tables can also have an initial lock mode.

anne-hobbs and others added 17 commits March 16, 2026 15:58
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@anne-hobbs
Copy link
Author

Screenshot 2026-03-18 at 13 26 40

Question regarding JSON Generation - left is the build result from here, right is the result from our Dev System. Something is running differently as I think the ENUM values for lock mode should be part of the JSON Schema, no?

@huber-nicolas
Copy link
Contributor

Screenshot 2026-03-18 at 13 26 40 Question regarding JSON Generation - left is the build result from here, right is the result from our Dev System. Something is running differently as I think the ENUM values for lock mode should be part of the JSON Schema, no?

the annotation "! $values { @link zah_aff_enqu_v1.data:co_lock_modes } is not correct.
Here zah_aff_enqu_v1 is not known

Yes, the enums should be in the json schema.

"! Only conflict check exclusive lock, as with 'E'
conflict_check_exclusive TYPE ty_lock_mode VALUE 'V',
"! <p class="shorttext">Conflict check for shared lock only, as with 'S'</p>
"! CaConflict check for shared lock only, as with 'S'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anne-hobbs We need to change the zero to big letter o for the lock mode text of 'R':
'R' Promote optimistic lock; transform from '0' to 'E'
'R' Promote optimistic lock; transform from 'O' to 'E'

The question regarding knowing what 'X' or 'R' or else is the same issue as in SAP GUI or ADT as before. So no need of change here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-object This is a new object type added to AFF

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants