Skip to content

Separate intentional HTTP 401 response checks from places where 403-only checks are needed. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gavbaa wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Separate intentional HTTP 401 response checks from places where 403-only checks are needed. #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2ce4b2
Separate intentional HTTP 401 response checks from places where 403-o…
Nov 15, 2021
6f94bd1
Merge branch 'adlnet:main' into split-401-403
gavbaa Dec 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lts/pkg/src/005-1-invalid-au/005-1-invalid-au.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,17 +98,17 @@ const saveLearnerPrefs = async (

return false;
}
// this treats non-401 and non-403 (like 400, 500, etc.) as not acceptable responses
// this treats non-403 (like 400, 500, etc.) as not acceptable responses
// for denying the request
// eslint-disable-next-line no-magic-numbers
else if (response.status !== 401 && response.status !== 403) {
else if (response.status !== 403) {
Helpers.storeResult(false, false, {reqId: "4.2.0.0-2", msg: `Save learner preferences response status code: ${response.status} ${responseContent} (Testing ${reqId})`});

return false;
}
}
catch (ex) {
// request should succeed, but provide a 401 or 403, so an exception here is an error
// request should succeed but provide a 403, so an exception here is an error
Helpers.storeResult(false, true, {reqId, msg: `Failed request to save learner preferences: ${ex}`});

return false;
Expand All @@ -135,7 +135,7 @@ const saveLearnerPrefs = async (
// send statement prior to getting auth token, with value
//
cmi5.setAuth("Basic Y2F0YXB1bHQ6ZmlyZSBzb21lIFJ1c3RpY2kgU29mdHdhcmUgcm9ja3Mh");
if (! await Helpers.sendStatement(cmi5, preInitializedSt, "8.1.2.0-2 (d)")) {
if (! await Helpers.sendStatement(cmi5, preInitializedSt, "8.1.2.0-2 (d)", {shouldSucceed: false, acceptUnauthorized: true})) {
return;
}

Expand Down Expand Up @@ -330,7 +330,7 @@ const saveLearnerPrefs = async (
const origAuth = cmi5.getAuth();

cmi5.setAuth("");
if (! await Helpers.sendStatement(cmi5, preInitializedSt, "8.1.2.0-5 (d)")) {
if (! await Helpers.sendStatement(cmi5, preInitializedSt, "8.1.2.0-5 (d)", {shouldSucceed: false, acceptUnauthorized: true})) {
return;
}

Expand Down Expand Up @@ -798,7 +798,7 @@ const saveLearnerPrefs = async (
return;
}

Helpers.storeResult(true, false, {msg: "LMS rejected set of statements with either 401 or 403 response status"});
Helpers.storeResult(true, false, {msg: "LMS rejected set of statements with 403 response status"});
};
/* eslint-enable padding-line-between-statements */

Expand Down
2 changes: 1 addition & 1 deletion lts/pkg/src/005-2-invalid-au/005-2-invalid-au.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ const execute = async () => {

await Helpers.closeAU(cmi5);

Helpers.storeResult(true, false, {msg: "LMS rejected set of statements with either 401 or 403 response status"});
Helpers.storeResult(true, false, {msg: "LMS rejected set of statements with 403 response status"});
};

execute();
2 changes: 1 addition & 1 deletion lts/pkg/src/006-launchMode/006-launchMode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const execute = async () => {
return;
}

Helpers.storeResult(true, false, {msg: "LMS rejected set of statements with either 401 or 403 response status"});
Helpers.storeResult(true, false, {msg: "LMS rejected set of statements with 403 response status"});

await Helpers.closeAU(cmi5);
};
Expand Down
2 changes: 1 addition & 1 deletion lts/pkg/src/007-1-multi-session/007-1-multi-session.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const execute = async () => {
return;
}

Helpers.storeResult(true, false, {msg: "LMS rejected set of statements with either 401 or 403 response status"});
Helpers.storeResult(true, false, {msg: "LMS rejected set of statements with 403 response status"});
}

await Helpers.closeAU(cmi5);
Expand Down
2 changes: 1 addition & 1 deletion lts/pkg/src/007-2-multi-session/007-2-multi-session.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ const execute = async () => {

await Helpers.closeAU(cmi5);

Helpers.storeResult(true, false, {msg: "LMS rejected set of statements with either 401 or 403 response status"});
Helpers.storeResult(true, false, {msg: "LMS rejected set of statements with 403 response status"});
}
};

Expand Down
11 changes: 8 additions & 3 deletions lts/pkg/src/lib/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,17 +152,22 @@ const Helpers = {

return false;
}
// this treats non-401 and non-403 (like 400, 500, etc.) as not acceptable responses
// treats specific tests for unauthorized requests as acceptable responses.
// eslint-disable-next-line no-magic-numbers
else if (stResponse.status === 401 && cfg.acceptUnauthorized) {
return true;
}
// this treats non-403 (like 400, 500, etc.) as not acceptable responses
// for denying the statement
// eslint-disable-next-line no-magic-numbers
else if (stResponse.status !== 401 && stResponse.status !== 403) {
else if (stResponse.status !== 403) {
Helpers.storeResult(false, false, {reqId: "4.2.0.0-2", msg: `Statement request status code: ${stResponse.status} ${stContent} (Testing ${reqId})`});

return false;
}
}
catch (ex) {
// request should succeed, but provide a 401 or 403, so an exception here is an error
// request should succeed so an exception here is an error
Helpers.storeResult(false, true, {reqId, msg: `Failed request to store statement: ${ex}`});

return false;
Expand Down