-
Notifications
You must be signed in to change notification settings - Fork 204
feat: make nostr host configurable #2377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make nostr host configurable #2377
Conversation
59ab0bb to
330a169
Compare
330a169 to
fca6aa8
Compare
|
Nice! |
|
Hey @jerryfletcher21. I am not using the traditional scripts. I saw the loopback IP in strfry.conf, but I decided not to change it, because it would need to be a different value anyway. I mean, if someone wants to run the nostr relay in a different host, the bind in strfry.conf should still be 127.0.0.1, or 0.0.0.0, or some other local interface IP. I am running my coordinator with a docker compose setup (not the one from robosats-deploy), and in my setup I had configured the nostr relay host with the hostname of the strfry container. By the way, can you help me with the tests? It looks like they are failing in the main branch. |
|
this is great @alicecoordinator can you please also create a PR in https://github.com/RoboSats/robosats-deploy to be compatible with this? |
|
@KoalaSat no changes in robosats-deploy are needed, since localhost will be used as default if the environment variable is not set. 👌 |
I understand, but I think it's better to make it explicit to avoid shadowy default values. |
KoalaSat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care @alicecoordinator
Please accept a small tip for your work. Share here a Ln invoice for 40,000 sats with a long expiration date
|
Thank you! |
What does this PR do?
Makes it possible for coordinators to configure the nostr relay host.
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.