Skip to content

Conversation

@alicecoordinator
Copy link
Contributor

@alicecoordinator alicecoordinator commented Jan 16, 2026

What does this PR do?

Makes it possible for coordinators to configure the nostr relay host.

Checklist before merging

  • Install pre-commit and initialize it: pip install pre-commit, then pre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.

@alicecoordinator alicecoordinator force-pushed the make-nostr-host-configurable branch from 59ab0bb to 330a169 Compare January 19, 2026 22:15
@alicecoordinator alicecoordinator force-pushed the make-nostr-host-configurable branch from 330a169 to fca6aa8 Compare January 19, 2026 22:50
@jerryfletcher21
Copy link
Contributor

jerryfletcher21 commented Jan 20, 2026

Nice!
Are you using the traditional scripts for your coordinator?
There is one other instance where you should add it, in traditional/templates/strfry.conf under relay -> bind.
And then adding the sed command in traditional/traditional-services strfry_setup as you did in nginx_setup.
Even though this will probably be used to run an external nost relay, so you will not run strfry locally.

@alicecoordinator
Copy link
Contributor Author

alicecoordinator commented Jan 20, 2026

Hey @jerryfletcher21. I am not using the traditional scripts.

I saw the loopback IP in strfry.conf, but I decided not to change it, because it would need to be a different value anyway. I mean, if someone wants to run the nostr relay in a different host, the bind in strfry.conf should still be 127.0.0.1, or 0.0.0.0, or some other local interface IP.

I am running my coordinator with a docker compose setup (not the one from robosats-deploy), and in my setup I had configured the nostr relay host with the hostname of the strfry container.

By the way, can you help me with the tests? It looks like they are failing in the main branch.

@KoalaSat
Copy link
Member

this is great @alicecoordinator can you please also create a PR in https://github.com/RoboSats/robosats-deploy to be compatible with this?

@alicecoordinator
Copy link
Contributor Author

@KoalaSat no changes in robosats-deploy are needed, since localhost will be used as default if the environment variable is not set. 👌

@KoalaSat
Copy link
Member

@KoalaSat no changes in robosats-deploy are needed, since localhost will be used as default if the environment variable is not set. 👌

I understand, but I think it's better to make it explicit to avoid shadowy default values.

@alicecoordinator
Copy link
Contributor Author

Copy link
Member

@KoalaSat KoalaSat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care @alicecoordinator

Please accept a small tip for your work. Share here a Ln invoice for 40,000 sats with a long expiration date

@KoalaSat KoalaSat merged commit a1f9203 into RoboSats:main Jan 27, 2026
8 checks passed
@alicecoordinator
Copy link
Contributor Author

Thank you!

lnbc400u1p5hjq0cpp55suxqad2jd476hzwhwqw6ngpc8ut5eg4gx9zru5c45fh8akqe03sdz2dp68gurn8ghj7emfw3582c3wvdhk6t6jda3x75mpw3ej7un0vfhhxct5wvhhqatvdshnyvehxucqzzsxq97zvuqsp57l444hfdux0c85swuvap3ydjx7c3vwg0w235ckkq2wm7cfqgcgus9qxpqysgquykczzrqgj3h5y93h83h48gvqqk5al5prj4wkjtd5xasdej4y558pksskams07uslusmg0uj936fn7kaqadjt36ytqet4nmgy80pw4sqwhhq6v

@alicecoordinator alicecoordinator deleted the make-nostr-host-configurable branch January 27, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants