rewrite and append with full file context#142
rewrite and append with full file context#142tommyengstrom wants to merge 1 commit intoRobitx:mainfrom
Conversation
|
@Robitx this looks awesome, could you merge? |
lua/gp/init.lua
Outdated
|
|
||
| M.Prompt = function(params, target, prompt, model, template, system_template, whisper) | ||
| -- enew, new, vnew, tabnew should be resolved into table | ||
| print(template) |
lua/gp/init.lua
Outdated
| return "" | ||
| end | ||
|
|
||
| _H.repo_instruct_file = function() |
lua/gp/config.lua
Outdated
| template_selection = "I have the following from {{filename}}:" | ||
| .. "\n\n```{{filetype}}\n{{selection}}\n```\n\n{{command}}", | ||
| template_rewrite = "I have the following from {{filename}}:" | ||
| template_rewrite = "I have the following awesome stuff from {{filename}}:" |
lua/gp/config.lua
Outdated
| agents = { | ||
| { | ||
| name = "ChatGPT4", | ||
| name = "ChatGPT4o", |
There was a problem hiding this comment.
Should we really switch to gpt-4o? I think it should be different PR
|
hehe. yeah, this is not intended as a final PR, just checking if there's interest. Should I go ahead an clean it up a bit? I.e. mostly doing what @quolpr suggested. |
|
Definitely interested! Thank you for creating this PR! Looks like there are conflicts to be resolved. |
|
+1 interested in this, and @quolpr suggestions such as extracting the 4o model change to a new PR. |
|
@Robitx Any thoughts on this? |
|
@tommyengstrom Hey, sorry for not looking into it sooner. Yes this is heading in a good direction, but I would like to prevent combinatorial explosion for commands based on the context, there are many possible contexts people might want to use:
So I would go in the direction of a separate set of commands similar to https://github.com/Robitx/gp.nvim?tab=readme-ov-file#agent-commands for switching the type of context which will be used by the commands such as GpRewrite. |
|
I suspect most of those examples are not really going to be used, thus making the "combinatorial explosion of commands" a non issue. I considered adding LSP output in this command but haven't done so. If done I don't see a point in having a separate command without it. Either way, I'm not interested in spending time on implementing that. |
|
I would also be interested in having the option to include the current file as context for visual append and rewrite commands. |
6 participants
This adds support for including the whole file in addition to the selected text in rewrite and append selection.
I don't expect this to be merged as is. Mostly wanted to ask if you'd like to add this if I clean it up a bit. Let me know what you think.