Open
Conversation
1 task
JamirLeal
requested changes
Nov 5, 2021
JamirLeal
left a comment
JamirLeal
left a comment
There was a problem hiding this comment.
Looks great, thank you Toño! I just left a minor comment
| height: 100vh; | ||
| } | ||
|
|
||
| /* Full-Size styles */ |
| justify-content: center; | ||
| align-items: center; | ||
| } | ||
| .small-size-slide>h1{ |
There was a problem hiding this comment.
According to the code standards could you please add a space before and after all the "{" or ">" appearings?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the necessary changes to replace the carousel customed implementations to instead use the Material-UI library.
The only carousel that was not using the Material-UI library was the carousel of the 'About' tab.
I did my best to keep the style exactly as it used to look with the previous implementation, the only UI-wise difference that can be identified is that the transition of images is now smoother and has an animation (provided by the library itself).