Skip to content

Expanded cell specialization effects#6826

Draft
Accidental-Explorer wants to merge 20 commits intomasterfrom
expanded-cell-specialization-effects
Draft

Expanded cell specialization effects#6826
Accidental-Explorer wants to merge 20 commits intomasterfrom
expanded-cell-specialization-effects

Conversation

@Accidental-Explorer
Copy link
Contributor

Brief Description of What This PR Does

This PR is intended to expand the cell specialisation bonus to affect more than just process speeds.

Derived from #6800, because I think it is quite likely that the specialisation calculation ends up using

Currently:

  • positive environmental tolerance effects from organelles.

Related Issues

  • Subjective: cell specialisation only has a smaller indirect benefit for cells specialising in non-process tasks like movement.
  • Subjective: cell specialisation can allow you to reduce ATP production parts, but that currently also drops your oxygen tolerance as a side effect if you're using oxygen metabolism.
  • Cell specialisation makes the bioluminescent vacuole worse by increasing its ATP consumption without improving its oxygen tolerance benefit. (At least for auto-evo, there is actually a cap on the consumption of luciferin, so the

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@Accidental-Explorer
Copy link
Contributor Author

For anyone seeing that last commit: I just implemented the calculations in the "lowest levels" possible to see everything that would have to be changed to match. So I am aware that it is 100% not efficient yet. Just want to see if I can get it to work yet.

(Also, on the gameplay side I got stuck on EndosymbiontOrganelleSystem/MicrobeReproductionSystem for now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

1 participant