Skip to content

LiPb: fix composition and molar mass calculation#306

Open
RemDelaporteMathurin wants to merge 1 commit intomainfrom
fix-lipb-density
Open

LiPb: fix composition and molar mass calculation#306
RemDelaporteMathurin wants to merge 1 commit intomainfrom
fix-lipb-density

Conversation

@RemDelaporteMathurin
Copy link
Copy Markdown
Owner

Following a report in #305 I looked at the source code of the database:

  • the way we calculated the molar mass was wrong
  • the composition for eutectic LiPb was wrong for some properties

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.79%. Comparing base (cc4ee9b) to head (b11d842).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #306   +/-   ##
=======================================
  Coverage   98.79%   98.79%           
=======================================
  Files          78       78           
  Lines        1906     1906           
=======================================
  Hits         1883     1883           
  Misses         23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RemDelaporteMathurin
Copy link
Copy Markdown
Owner Author

@diaz-alvarez

This is the plot that is now generated by HTM with

import h_transport_materials as htm
import matplotlib.pyplot as plt

lipb_sol = htm.solubilities.filter(material=htm.LIPB)

plt.figure()
plt.gca().yaxis.units = htm.ureg.mol * htm.ureg.m**-3 * htm.ureg.Pa**-0.5
htm.plotting.plot(lipb_sol)

plt.yscale("log")

plt.show()
image

Is this similar to what you have? Could you share your workflow for easier comparison?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant