Skip to content

Conversation

@GuyAv46
Copy link
Collaborator

@GuyAv46 GuyAv46 commented Jan 11, 2026

Describe the changes in the pull request

Remove unused vector collecting and sorting

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

@jit-ci
Copy link

jit-ci bot commented Jan 11, 2026

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

@codecov
Copy link

codecov bot commented Jan 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.13%. Comparing base (f5e69ac) to head (d45db22).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #886      +/-   ##
==========================================
- Coverage   97.13%   97.13%   -0.01%     
==========================================
  Files         129      129              
  Lines        7615     7611       -4     
==========================================
- Hits         7397     7393       -4     
  Misses        218      218              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the redundant neighbors_to_remove parameter and related operations from the HNSW index repair functionality. The parameter was being populated and sorted but never actually used in the function logic, resulting in unnecessary computational overhead.

Changes:

  • Removed unused neighbors_to_remove parameter from mutuallyUpdateForRepairedNode function
  • Eliminated redundant vector allocations, insertions, and sorting operations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GuyAv46 GuyAv46 changed the title remove redundant work Remove Redundant Operations - [MOD-13475] Jan 12, 2026
@GuyAv46 GuyAv46 added this pull request to the merge queue Jan 12, 2026
github-merge-queue bot pushed a commit that referenced this pull request Jan 12, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 12, 2026
@GuyAv46 GuyAv46 added this pull request to the merge queue Jan 12, 2026
Merged via the queue into main with commit 8a568cb Jan 12, 2026
32 checks passed
@GuyAv46 GuyAv46 deleted the guyav-remove_redundancy branch January 12, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants