-
Notifications
You must be signed in to change notification settings - Fork 1k
switch output format in vignettes to litedown html #7628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I just noticed that we can test this locally with |
|
Looks like the fix in cd98747 was necessary, because when the vignette is rendered, the current directory is The So now it should be fine, right? |
|
When running locally I now get due to cd98747 litedown::fuse('vignettes/ru/datatable-intro.Rmd')
# Warning message:
# In normalizePath(dirname(context)) :
# path[1]="vignettes/ru": No such file or directory |
aitap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing the issues I had missed!
Just check against "vignettes/foo.Rmd" or (implied ./)"bar.Rmd".
I think it's ready to be merged. |
|
Yeah, I also just checked locally and everything looks fine. TY! |
Follow up to #7534
Currently the translation links are only correctled rendered and displayed for the english vignettes
CI output