Upgrade YamlDotNet - Closes #121#130
Open
fireflycons wants to merge 4 commits intoRamblingCookieMonster:masterfrom
Open
Upgrade YamlDotNet - Closes #121#130fireflycons wants to merge 4 commits intoRamblingCookieMonster:masterfrom
fireflycons wants to merge 4 commits intoRamblingCookieMonster:masterfrom
Conversation
added 4 commits
October 6, 2019 13:58
- Version 7.0 for NET 3.5, 4.5 and NEtStandard 1.3 (for pswh) - Change loader to select appropriate DLL - Change Shadow-Copy to place DLL into versioned subdirectory so no issues if powershell and pwsh both running.
If the build preinstalls the previous version of PSDeploy, it will mask the loading of the new YamlDotNet version during the test run. It does mean that this build will probably fail at the deploy phase
This reverts commit 64de4c0.
Author
|
I also note that some tests fail locally, when there's no failures in AppVeyor. This was using the version I forked - prior to any edits. Something's leaking into the pipeline? |
This was referenced Oct 6, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Borrowing slightly from powershell-yaml, this change upgrades the PSYaml submodule to use YamlDotNet 7.0
It has the following features
pwshdoesn't overwrite the shadow forpowershell.Noted an issue while testing. In the build sequence, PSDepends is used to load the current version of PSDeploy from the gallery. This installs its own shadow of YamlDotNet which masks the loading of the newer version due to the logic in the fourth point above. I have run the tests with PSDeploy commented out of the requirements file.