You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add support for two new types of beams which are the two parts that FHD decomposes Jones matrices (E-field beams) into.
While these are needed by FHD, I suspect they might be more broadly useful to other simulators as well. I currently need them for pyFHD and it really makes the most sense to implement them on UVBeam because the decomposition needs to be done before interpolation.
The two new types of beams are:
The response of each feed to unpolarized emission. This is a complex quantity with Naxes_vec=1 (because this is the response to unpolarized emission) and a feed axis of length Nfeeds. The complex phase is related to time delays which can vary across the sky but are shared between the two incident polarizations. This is currently called "feed_iresponse" but I'm very open to other names.
The part that remains after dividing the Jones matrix by the above quantity for each feed and incident polarization direction. This represents how much each feed responds to each incident polarization direction. This is similar to a rotation matrix in that it effectively projects from the incident polarization vector directions to the directions of the feeds (the magnitude of the response is removed), but is not unitary because the projection of the feeds are not orthogonal in all directions on the sky. This is a complex quantity with the same shape as the efield beam (Jones matrix). This is currently called "feed_projection" but I'm very open to other names.
This PR adds support for these two new kinds of beams to UVBeam, AnalyticBeam and BeamInterface objects.
To Do:
decide on good names for these beam types!
update the tutorial (not sure how much to do here)
update the changelog
Note:
This PR is branched off of #1639, so it includes those updates and that PR should be merged first.
Motivation and Context
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.92%. Comparing base (2ca5e6f) to head (d608b33). ⚠️ Report is 1 commits behind head on main.
@bhazelton can I perhaps suggest per_feed_unpolarized_response instead of feed_iresponse? It's more of a mouthful, but more descriptive. I dunno what to call the other.... feed_projection is maybe OK. Projection is not very descriptive, but I honestly don't understand the formulation here well enough to suggest otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for two new types of beams which are the two parts that FHD decomposes Jones matrices (E-field beams) into.
While these are needed by FHD, I suspect they might be more broadly useful to other simulators as well. I currently need them for pyFHD and it really makes the most sense to implement them on UVBeam because the decomposition needs to be done before interpolation.
The two new types of beams are:
This PR adds support for these two new kinds of beams to UVBeam, AnalyticBeam and BeamInterface objects.
To Do:
Note:
This PR is branched off of #1639, so it includes those updates and that PR should be merged first.
Motivation and Context
Types of changes
Checklist:
New feature checklist: