feat: qrl refactor #8227
Draft
feat: qrl refactor #8227
+618
−657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wmertens
force-pushed
the
v2-qrl-refactor
branch
7 times, most recently
from
1700e68 to
f6aa868
Compare
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
- store captured refs and serialization in same property - store container directly - simplify qrl parsing with `#` delimiter - move captures out of context into a simple module scoped variable. This is possible because the captures are always read once, synchronously - simplify qrl creation, making methods as reusable as possible - simplify qrl resolution and calling - pass captures from qwikloader via `this`, simplifying qwikloader and removing global context - change unit test dispatching to be more like qwikloader - QRLs no longer need inflation during deserialization Co-authored-by: Varixo <[email protected]>
wmertens
force-pushed
the
v2-qrl-refactor
branch
from
f6aa868 to
07fba84
Compare
Member
|
Please ping me when ready for review. I'd like to test those changes with some tweaks to see if we can still reduce user event preloads waterfalls to zero without insights. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.