Fix: Resolve Windows startup/exit hangs and shell warnings #1175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix DeprecationWarning in shellExecutionService by removing empty args. - Add timeout to PowerShell IDE detection to prevent startup hangs. - Add timeout to IdeClient initialization to allow other commands to load. - Add timeout to exit cleanup to prevent process hanging on quit. - Ensure commands are reloaded after IDE detection completes.
Contributor
📋 Review SummaryThis PR addresses critical stability issues on Windows where the CLI would hang during startup and exit, and also fixes a Node.js deprecation warning. The changes implement timeout mechanisms for critical blocking operations and fix API usage for shell execution. Overall, this is a solid improvement to the reliability and user experience of the CLI, particularly for Windows users. 🔍 General Feedback
🎯 Specific Feedback🔴 CriticalNo specific issues identified in this review. 🟡 HighNo specific issues identified in this review. 🟢 Medium
🔵 Low
✅ Highlights
|
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses critical stability issues on Windows where the CLI would hang during startup (preventing commands like /quit from loading) and during exit. It also fixes a Node.js deprecation warning related to shell execution.
Problem
Startup Hang: On some Windows machines, the PowerShell command used to detect the IDE environment (Get-CimInstance) can be extremely slow or unresponsive. This blocked the initialization of IdeClient, which in turn blocked the loading of all built-in commands. As a result, the CLI would start, but typing / would show no commands, and /quit would not work.
Exit Hang: When running /quit or pressing Ctrl+C, the application attempts to disconnect the IdeClient. If the detection process was still stuck, this cleanup step would also hang, preventing the process from terminating.
Deprecation Warning: Using spawn with shell: true and an empty arguments array caused a Node.js DeprecationWarning.
Solution
Implemented timeout mechanisms for critical blocking operations and fixed the API usage for shell execution.
Detailed Changes
shellExecutionService.ts
Removed the empty args array [] when calling spawn with shell: true to resolve the DeprecationWarning.
process-utils.ts
Added a 5-second timeout to the PowerShell execution used for IDE detection. This prevents the detection logic from hanging indefinitely.
ideCommand.ts
Added a 1-second timeout to IdeClient.getInstance() during the initial command loading phase.
If initialization takes longer than 1s, a placeholder /ide command is registered immediately. This ensures that other critical commands (like /quit, /help) are available to the user instantly, without waiting for slow IDE detection.
slashCommandProcessor.ts
Added a listener to trigger reloadCommands() once IdeClient initialization completes. This ensures that the full /ide command functionality becomes available automatically once the background detection finishes.
AppContainer.tsx
Added a 2-second timeout to the exit cleanup logic. If disconnecting the IDE client takes too long, the process will force exit
, ensuring the CLI remains responsive to termination requests.
Impact
Windows Users: significantly improved startup reliability and exit responsiveness. The CLI is now guaranteed to be usable immediately after launch, even if the system's PowerShell is slow.
All Users: Cleaner console output (no deprecation warnings).