Improve record getter handling#340
Merged
ix0rai merged 8 commits intoQuiltMC:develop/2.8from Jan 30, 2026
Merged
Conversation
713cc89 to
802004f
Compare
802004f to
31570a5
Compare
RecordIndexingVisitor: only check bytecode if multiple methods are getter candidates; allows finding overrides in simple cases RecordIndexingVisitor: when there are multiple getter candidates, check name and descriptor in addition to bytecode; prevents some false-positives in getter finding (though false positives for non-getters are still possible)
31570a5 to
79020ef
Compare
Member
Author
|
ready! |
ix0rai
approved these changes
Jan 29, 2026
Member
ix0rai
left a comment
There was a problem hiding this comment.
looks great! i left a bunch of suggestions to make the javadoc easier to read
enigma/src/main/java/org/quiltmc/enigma/impl/plugin/RecordIndexingService.java
Outdated
Show resolved
Hide resolved
enigma/src/main/java/org/quiltmc/enigma/impl/plugin/RecordIndexingService.java
Outdated
Show resolved
Hide resolved
enigma/src/main/java/org/quiltmc/enigma/impl/plugin/RecordIndexingService.java
Outdated
Show resolved
Hide resolved
enigma/src/main/java/org/quiltmc/enigma/impl/plugin/RecordIndexingService.java
Outdated
Show resolved
Hide resolved
enigma/src/main/java/org/quiltmc/enigma/impl/plugin/RecordIndexingService.java
Outdated
Show resolved
Hide resolved
enigma/src/main/java/org/quiltmc/enigma/impl/plugin/RecordIndexingService.java
Outdated
Show resolved
Hide resolved
enigma/src/main/java/org/quiltmc/enigma/impl/plugin/RecordIndexingService.java
Outdated
Show resolved
Hide resolved
enigma/src/main/java/org/quiltmc/enigma/impl/plugin/RecordIndexingService.java
Outdated
Show resolved
Hide resolved
enigma/src/main/java/org/quiltmc/enigma/impl/plugin/RecordIndexingService.java
Outdated
Show resolved
Hide resolved
enigma/src/main/java/org/quiltmc/enigma/impl/plugin/RecordIndexingService.java
Outdated
Show resolved
Hide resolved
...java/org/quiltmc/enigma/input/records/name_mismatch/StringComponentOverrideGetterRecord.java
Outdated
Show resolved
Hide resolved
Co-authored-by: ix0rai <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on #339 to avoid having to work aroundrebasedSearchMappingsTestImproves how
RecordIndexingVisitorfinds record getters:toString, etc.) are considered getter candidatesAdditionally, this exposes methods differentiating between "definite" and "probable" getters in
RecordIndexingServicebecause #333 will disallow directly naming definite getters (this PR was extracted from #333)