Use swift package traits to make Nimble an optional component.#38
Open
Use swift package traits to make Nimble an optional component.#38
Conversation
younata
force-pushed
the
package-traits
branch
from
e53d3cf to
cc9d877
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change, wait until v2 to merge.
This makes the Nimble integration a package trait. Useful for those who want to use this library without also having to depend on Nimble.
It also reimplements the tests to use Swift Testing - because I already had to make changes to drop Nimble usage in the tests. This will improve test performance, not that these were slow in the first place.