Fix count_ops memory cleanup and expose QuantumCircuit.count_ops#33
Merged
garrison merged 7 commits intoQiskit:mainfrom Apr 26, 2026
Merged
Fix count_ops memory cleanup and expose QuantumCircuit.count_ops#33garrison merged 7 commits intoQiskit:mainfrom
count_ops memory cleanup and expose QuantumCircuit.count_ops#33garrison merged 7 commits intoQiskit:mainfrom
Conversation
|
|
Contributor
Author
|
@garrison whenever you are free, please take a look. Thanks! |
|
coverage: 72.956% (+0.5%) from 72.495% — arnavk23:fix-issue-21-count-ops into Qiskit:main |
Contributor
Author
|
@garrison all checks pass |
garrison
reviewed
Apr 24, 2026
Member
garrison
left a comment
garrison
left a comment
There was a problem hiding this comment.
Thank you for making this contribution 🚀
garrison
reviewed
Apr 25, 2026
garrison
reviewed
Apr 26, 2026
Co-authored-by: Jim Garrison <jim@garrison.cc>
garrison
reviewed
Apr 26, 2026
garrison
approved these changes
Apr 26, 2026
Member
garrison
left a comment
garrison
left a comment
There was a problem hiding this comment.
This looks great, now the only thing left is getting coveralls CI to pass.
garrison
reviewed
Apr 26, 2026
Member
|
Could you please try the following? git fetch origin main:main
git merge main
git push |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes the
qk_circuit_count_opswrapper so it always releases the allocatedQkOpCountsbuffer returned by the C API, preventing a memory leak. It also exposescount_opsas aQuantumCircuitproperty for parity with the existing circuit API.Changes
c_circuit.jlto wrapqk_circuit_count_opsin a try/finally block and callqk_opcounts_clearafter converting the result.count_opstoQuantumCircuitproperty dispatch incircuit.jl.test_circuit.jlcovering bothqk_circuit_count_ops(qc)andqc.count_ops.