Replace deprecated datetime.datetime.utcnow#480
Open
kajinamit wants to merge 1 commit intoPylons:mainfrom
Open
Replace deprecated datetime.datetime.utcnow#480kajinamit wants to merge 1 commit intoPylons:mainfrom
kajinamit wants to merge 1 commit intoPylons:mainfrom
Conversation
21641ad to
1e799b5
Compare
|
Related issue #473 |
71a2f91 to
46d284e
Compare
Contributor
|
Duplicate of #475 and does a lot more - looks like you ran an auto-formatter or something changed a lot more lines than is relevant? |
The utcnow function was deprecated in Python 3.12[1]. Note that all datetime instances are kept non-timezone-aware to keep backword-compatibility. [1] https://docs.python.org/3.13/library/datetime.html#datetime.datetime.utcnow
Author
That was due to the base commit to fix the lint check error. I removed that commit, because it was merged separately. |
mmerickel
reviewed
Mar 31, 2026
| "parse_date", | ||
| "serialize_date", | ||
| "parse_date_delta", | ||
| "serialize_date_delta", |
Member
There was a problem hiding this comment.
I think utcnow should be added to __all__ since this module is following that pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The utcnow function was deprecated in Python 3.12[1].
Note that all datetime instances are kept non-timezone-aware to keep backword-compatibility.
[1] https://docs.python.org/3.13/library/datetime.html#datetime.datetime.utcnow