Break up CI build into JVM, JS, and Native, & upgrade JDK.#72
Merged
davesmith00000 merged 3 commits intomainfrom Mar 14, 2026
Merged
Break up CI build into JVM, JS, and Native, & upgrade JDK.#72davesmith00000 merged 3 commits intomainfrom
davesmith00000 merged 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR restructures CI to make failures easier to re-run by splitting the single build job into separate JVM/JS/Native jobs, and upgrades the CI JDK to Temurin 17.
Changes:
- Split the GitHub Actions workflow into
jvm,js, andnativejobs with platform-specific Mill targets. - Upgrade JDK from AdoptOpenJDK 11 to Temurin 17 in CI.
- Remove the top-level
ci.shscript previously used to run all CI tasks in one place.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| ci.sh | Removes the monolithic CI runner script that executed all Mill tasks sequentially. |
| .github/workflows/ci.yml | Introduces split jobs for JVM/Scala.js/Scala Native and bumps CI JDK to Temurin 17. |
Comments suppressed due to low confidence (1)
ci.sh:1
- Removing
ci.sheliminates a single local entry point for running CI tasks and forces the workflow to duplicate the command list. Consider keeping a script (or introducingci-jvm.sh/ci-js.sh/ci-native.sh, or a single script with a platform argument) and invoking it from the workflow to keep CI and local runs aligned.
The original idea was to fail fast on the JVM build, but the JVM platform does not cover all modules, and no build artfacts are shared, so the benefit is questionable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aim is to be able to re-run sub-sections of the failing build by splitting it into jobs. Often the JVM will be fine, but Native will fail, for example.
Relates to: #71