feat(plugin-api) Add fine-grained player permission control to plugin API.#2059
Open
StormLight14 wants to merge 8 commits intoPumpkin-MC:masterfrom
Open
feat(plugin-api) Add fine-grained player permission control to plugin API.#2059StormLight14 wants to merge 8 commits intoPumpkin-MC:masterfrom
StormLight14 wants to merge 8 commits intoPumpkin-MC:masterfrom
Conversation
Signed-off-by: StormLight14 <[email protected]>
…lugin api Signed-off-by: StormLight14 <[email protected]>
Signed-off-by: StormLight14 <[email protected]>
Signed-off-by: StormLight14 <[email protected]>
Signed-off-by: StormLight14 <[email protected]>
Signed-off-by: StormLight14 <[email protected]>
Signed-off-by: StormLight14 <[email protected]>
GreenedDev
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
set_permission,unset_permission, andhas_permission_setmethods on the Player resource, allowing plugins to control and get the values of specific permission nodes for players.These methods were implemented using the already existing methods from
PermissionAttachment.Testing
I tested each of the new methods by making a simple permissions plugin and they all seem to work as expected.
cargo clippy --all-targets✅cargo test✅