Skip to content

feat: implement coral plants, coral fans and fix coral feature#2025

Open
GreenedDev wants to merge 6 commits intoPumpkin-MC:masterfrom
GreenedDev:fix/coral-placing
Open

feat: implement coral plants, coral fans and fix coral feature#2025
GreenedDev wants to merge 6 commits intoPumpkin-MC:masterfrom
GreenedDev:fix/coral-placing

Conversation

@GreenedDev
Copy link
Copy Markdown
Collaborator

@GreenedDev GreenedDev commented Apr 14, 2026

Description

Implemented coral plants and coral fans, their placing rules and behavior (dying without water)
Fix coral feature (placing)
2026-04-14_12 46 43

@GreenedDev GreenedDev added bug Something isn't working waiting-for-testing Pull requests that need to be tested by a maintainer worldgen World or chunk generation related block Anything block-related labels Apr 14, 2026
@pizzapunt53820
Copy link
Copy Markdown

pizzapunt53820 commented Apr 14, 2026

The coral in this pull request doesn't replicate vanilla 26.1 yet in this seed.

Schermafdruk van 2026-04-14 15-22-19 Left: Vanilla

Right: Pumpkin

Seed: 873465098712865
Coordinates: 2698.5 51 -2699.5 facing north

@GreenedDev
Copy link
Copy Markdown
Collaborator Author

doesn't replicate vanilla 26.1

this PR didn't add that behavior. It was already there. This pr is only supposed to fix coral blocks hanging in water without support blocks.

@pizzapunt53820
Copy link
Copy Markdown

pizzapunt53820 commented Apr 14, 2026

Ok, then i read the title wrong. When i break a coral block, all connected coral fans or coral plants disappear. There are also no hovering coral fans generated in the same seed. All coral plants can be placed in the same places as in vanilla. The only issue i have is that specifically dead coral fans cannot be placed on the side of blocks, so only on top of blocks. This seems to work correctly on the normal branch.

Example of what is possible in vanilla:
Schermafdruk van 2026-04-14 17-59-02

Comment thread pumpkin/src/block/blocks/plant/coral_fan.rs
@GreenedDev
Copy link
Copy Markdown
Collaborator Author

should be fixed now

@GreenedDev GreenedDev removed waiting-for-testing Pull requests that need to be tested by a maintainer labels Apr 14, 2026
@pizzapunt53820
Copy link
Copy Markdown

pizzapunt53820 commented Apr 14, 2026

The dead coral fan placement works now, but it seems that this pull request makes the server hang much more frequently than the main branch. For me, this pull requests works for a few seconds before the server stops responding and the main branch server keeps responding for multiple minutes. I don't know if this is caused by the changes or by the different build and if it is relevant.

@GreenedDev
Copy link
Copy Markdown
Collaborator Author

The dead coral fan placement works now, but it seems that this pull request makes the server hang much more frequently than the main branch. For me, this pull requests works for a few seconds before the server stops responding and the main branch server keeps responding for multiple minutes. I don't know if this is caused by the changes or by the different build and if it is relevant.

i haven't noticed that

@pizzapunt53820
Copy link
Copy Markdown

i haven't noticed that

Then i guess the server hang in my case is not caused by this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

block Anything block-related bug Something isn't working worldgen World or chunk generation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants