Skip to content

fix: (player) potion effect crash#2012

Open
RoosterBooster007 wants to merge 2 commits intoPumpkin-MC:masterfrom
RoosterBooster007:fix/potion-panic
Open

fix: (player) potion effect crash#2012
RoosterBooster007 wants to merge 2 commits intoPumpkin-MC:masterfrom
RoosterBooster007:fix/potion-panic

Conversation

@RoosterBooster007
Copy link
Copy Markdown
Collaborator

Description

  • Falls back to the attribute.default_value if no attribute base is found for a LivingEntity, preventing a panic.

Testing

  • Doesn't crash, but the default speed attribute (0.7) is used for players rn, causing extreme speed effects (instead of the correct 0.1). The right attribute defaults aren't present for players (in entity_type.rs) atm.

@RoosterBooster007 RoosterBooster007 added bug Something isn't working panic Bugs that cause crashes or are otherwise extreme labels Apr 11, 2026
@Snowiiii
Copy link
Copy Markdown
Member

is this the same as #1990 ?, does it fix the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working panic Bugs that cause crashes or are otherwise extreme

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants