feat(command): identifier parsing & argument type#2000
Open
Laptop59 wants to merge 2 commits intoPumpkin-MC:masterfrom
Open
feat(command): identifier parsing & argument type#2000Laptop59 wants to merge 2 commits intoPumpkin-MC:masterfrom
Laptop59 wants to merge 2 commits intoPumpkin-MC:masterfrom
Conversation
Laptop59
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to create an argument type
IdentifierArgumentTypethat can parse identifiers.However, since we don't actually have a structure with namespace and path separated, this PR also adds an new struct
Identifierinpumpkin-util.Identifierconsists of both a namespace and a path, each stored as aCow<'static, str>. Not for registries, but for identifying user-generated content (like bossbars) which cannot be fully represented by&'static strs.We need an argument type for this as commands like
/bossbar,/random, and/waypointtake an identifier which is user-generated and not associated with any registry.Maybe if we want to parse item IDs later for example in a new argument type, we can first parse an
Identifierusingfrom_readerand then check if an item under that identifier does exist.Testing
Added new tests for creating and parsing
Identifiers, and they all pass.