Closed
Conversation
vicsn
reviewed
Aug 12, 2025
| if let Err(e) = bft_sender.tx_sync_bft_dag_at_bootup.send(certificates).await { | ||
| bail!("Failed to update the BFT DAG from sync: {e}"); | ||
| // We need certificates to send. | ||
| if !certificates.is_empty() && !leader_certificates.is_empty() { |
Collaborator
There was a problem hiding this comment.
Hmm this might be outdated code, I guess Kai removed this in a recent iteration, shall we remove Kai? Then I guess we also won't have to collect the leader_certificates above anymore.
| ); | ||
| }; | ||
| // Add the transmission to the set. | ||
| transmissions.insert(*transmission_id, transmission); |
Collaborator
There was a problem hiding this comment.
Seems like I left a bug in here, we should populate seen_solution_ids and seen_transaction_ids like we did before
ljedrz
force-pushed
the
perf/compact_subdag
branch
from
4c1aad8 to
414bd32
Compare
10 tasks
kaimast
force-pushed
the
perf/compact_subdag
branch
3 times, most recently
from
27a04fa to
e92dc1e
Compare
Signed-off-by: ljedrz <[email protected]> Co-authored-by: ljedrz <[email protected]>
kaimast
force-pushed
the
perf/compact_subdag
branch
from
e92dc1e to
62816f1
Compare
Contributor
|
Closing this in favor of #3998. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A revival of #3000.
Filing as a draft, as it's the initial implementation, and I hope to remove the reliance on full subdags.