fix: reorder exports so types is first and update repository URL #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi! This PR fixes the types first warning in package.json (issue #216). I’ve verified it with npx publint — no errors. Thank you for reviewing! |
Member
There was a problem hiding this comment.
Thanks for this @sau240 .
Just a heads up that another contributor already reached out in the issue and opened a PR for this, so will defer to their PR first at least for now.
I will still keep this open for a little bit to see how that review goes, but will plan to merge that one first assuming all PR feedback gets resolved in a timely manner.
| "types": "./src/index.d.ts", | ||
| "import": "./src/wcc.js", | ||
| "types": "./src/index.d.ts" | ||
| "require": "./src/wcc.js" |
Member
There was a problem hiding this comment.
I don't think we need this require, I don't need it to make publint pass as long as the types come first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… URL
Related Issue
Resolves #216 — Fix publint feedback for package.json
Summary of Changes