chore: #210 use self-closing tags in tests #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <img src="https://www.greenwoodjs.io/assets/greenwood-logo-og.png" alt="Greenwood logo"> | ||
| <br> | ||
| <img src="https://www.greenwoodjs.io/assets/greenwood-logo-og.png" alt="Greenwood logo" /> | ||
| <br /> |
Member
There was a problem hiding this comment.
hmm, I thought the issue was that the expected would be without the closing / for these void elements?
I can understand if we start with <img/> but end up with <img> but shouldn't parse5 be stripping the closing / and thus the expected should be <img>?
| pictureFrame = dom.window.document.querySelectorAll('wcc-picture-frame'); | ||
| expectedHtml = await fs.readFile(new URL('./expected.html', import.meta.url), 'utf-8'); | ||
| const rawExpectedHtml = await fs.readFile(new URL('./expected.html', import.meta.url), 'utf-8'); | ||
| expectedHtml = serialize(parseFragment(rawExpectedHtml)); |
Member
There was a problem hiding this comment.
Oh, I see yes, you said you would run the expected HTML through parse5, thus getting our compliant HTML output.
Maybe we can just leave a comment here regarding this just to add a little context for this change here?
thescientist13
changed the title
thescientist13
force-pushed
the
kprince/fix-test-with-void-tags
branch
from
52ad4f7 to
43b2f4f
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates a test to use self-closing tags. This will make it compatible with Prettier and unblock #209 using self closing tags in the test files, but running them through parser5 in the tests, we get the best of both world: compliant html & auto formatting.
Related Issue
Resolves #210
Summary of Changes
/>to a test expected.html file