Fix to channel specification in 3d_autoencoderkl notebook #1925
Merged
KumoLiu merged 8 commits intoProject-MONAI:mainfrom Jan 21, 2025
Merged
Fix to channel specification in 3d_autoencoderkl notebook #1925KumoLiu merged 8 commits intoProject-MONAI:mainfrom
KumoLiu merged 8 commits intoProject-MONAI:mainfrom
Conversation
Signed-off-by: Virginia <[email protected]>
Signed-off-by: Virginia <[email protected]>
Signed-off-by: Virginia <[email protected]>
Signed-off-by: Virginia <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Virginia Fernandez <[email protected]>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
KumoLiu
approved these changes
Jan 21, 2025
Contributor
KumoLiu
left a comment
KumoLiu
left a comment
There was a problem hiding this comment.
Thanks for the fix, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1924
Modification of channel definition within 3d_autoencoderkl notebook.
Description
The variable "channel" was wrongly defined after the transforms.
I have re-run the plot for channel = 2 and it runs fine.
Checks
./runner.sh -t <path to .ipynb file>