Consolidate RedHerb's NeoWikiGetFrontendModules handlers#810
Merged
Conversation
RedHerb had two classes implementing NeoWikiGetFrontendModulesHook: RedHerbFrontendHook (added with the Color frontend) and RedHerbFrontendModulesHook (added later with the sidebar dialogs). The split was incidental — a later PR added a new file instead of editing the existing one — and there's no functional reason for two classes when one handler can append all three modules. Merge the body of RedHerbFrontendHook into RedHerbFrontendModulesHook and remove the redundant class and its extension.json registration. No behavior change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows-up to #780 and #781
RedHerb had two classes implementing NeoWikiGetFrontendModulesHook:
RedHerbFrontendHook (added with the Color frontend) and
RedHerbFrontendModulesHook (added later with the sidebar dialogs). The
split was incidental — a later PR added a new file instead of editing
the existing one — and there's no functional reason for two classes
when one handler can append all three modules.
Merge the body of RedHerbFrontendHook into RedHerbFrontendModulesHook
and remove the redundant class and its extension.json registration. No
behavior change.