Fix PHP 8.4 implicit nullable parameter deprecations#891
Merged
Conversation
Fixes #890 PHP 8.4 deprecates implicitly marking a parameter as nullable by giving it a default value of null without an explicit nullable type. Add the explicit `?` prefix to the affected parameters. Note: The deprecation warnings emitted by `mediawiki/parser-hooks` (e.g. ParserHooks\FunctionRunner, ParserHooks\Internal\Runner, ParserHooks\HookRunner) originate from that library and need to be fixed there. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #890
PHP 8.4 deprecates implicitly marking a parameter as nullable by giving it a default value of null without an explicit nullable type. Add the explicit
?prefix to the affected parameters:MapsDistanceParser::parseAndFormatMapsDistanceParser::formatDistanceMapsDistanceParser::getUnitRatioMapsDistanceParser::getValidUnit(same pattern, not in the issue's stack trace but would warn under different code paths)CoordinateValue::getFormattedCoordDisplayMapRenderer::__constructAreaDescription::__constructThe deprecation warnings emitted by
mediawiki/parser-hooks(ParserHooks\FunctionRunner,ParserHooks\Internal\Runner,ParserHooks\HookRunner) originate from that library and need to be fixed in https://github.com/JeroenDeDauw/ParserHooks.Test plan
🤖 Generated with Claude Code