Skip to content

Merge updates to current upstream#3841

Draft
GenerelSchwerz wants to merge 133 commits intoPrismarineJS:masterfrom
GenerelSchwerz:master
Draft

Merge updates to current upstream#3841
GenerelSchwerz wants to merge 133 commits intoPrismarineJS:masterfrom
GenerelSchwerz:master

Conversation

@GenerelSchwerz
Copy link
Contributor

No description provided.

StarWeizz and others added 3 commits February 14, 2026 15:12
Fixes PrismarineJS#3764

This commit adds proper handling of the configuration phase introduced
in Minecraft 1.20.2 and extended in 1.21+, which is required for server
transfers via Velocity proxy.

Changes:
- New velocity plugin to manage configuration phase state
- Modified physics plugin to block movement packets during configuration
- Automatic resource pack acceptance during configuration phase
- New examples demonstrating Velocity proxy connection and transfers

The bot will no longer be kicked with 'Disconnected, while in
configuration phase' errors during Velocity server transfers.
The velocity plugin was activating during the initial 1.20.2+ login
configuration phase, which is already handled by node-minecraft-protocol.
This caused duplicate finish_configuration packets and disabled physics
during login, making the bot unable to spawn on 1.20.2+ servers.

Changes:
- Only activate configuration phase handling after first spawn
- Remove duplicate finish_configuration write (minecraft-protocol handles it)
- Remove redundant registry_data/select_known_packs listeners
- Fix missing newlines at EOF (lint errors)
- Fix object-shorthand lint warnings

Co-authored-by: Cursor <[email protected]>
@socket-security
Copy link

socket-security bot commented Feb 21, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​nxg-org/​mineflayer-physics-util@​1.8.1978100759370
Addedmineflayer-pathfinder@​2.4.58910010080100

View full report

@socket-security
Copy link

socket-security bot commented Feb 21, 2026

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@GenerelSchwerz GenerelSchwerz marked this pull request as draft February 21, 2026 20:51
@@ -1,5 +1,5 @@
// This example will shoot the player that said "fire" in chat, when it is said in chat.
const mineflayer = require('mineflayer')
const mineflayer = require('../')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted

@GenerelSchwerz
Copy link
Contributor Author

Re-visiting this.

I've merged a few various PRs into this fork, including: #3834 and @bindotmasterpro 's fork.

@GenerelSchwerz
Copy link
Contributor Author

All tests pass.

Improvements include:

  • Overall better physics implementation (support for pose updates, better modern version support, inter-operability with pre-existing prismarine-physics).
  • Match rotational interpolation to actual physics of the bot, removing the desync of sent packet data and known yaw/pitch data.
  • Better rounding for positional updates sent out (more closely matches java implementation)
  • support for velocity proxies, mentioned previously
  • minor tweaks/improvements to various components of mineflayer.

At this point, I cannot separate this PR into other sections since I've been maintaining my own fork. This PR is fully up-to-date with current upstream and passes all tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants