Fix crash issue when trying to parse bad skin JSON

[TheSharkyOfficial]

Bad skin JSON sometimes occur with NPC players on servers, this will fix the JSON by adding missing quotes if found.

Example of JSON of a NPC player (notice the missing quotes) :

{textures:{SKIN:{url:"http://textures.minecraft.net/texture/b67168621fdb0cf3f7e57cb5166d48e9e9c87d677494339f3b8feec8c3a36b"}}}

For comparison, this is what a normal player skin data looks like :

{
  "timestamp" : 1754070097924,
  "profileId" : "ec7732e7890547fdae796508b583fef3",
  "profileName" : "wtfsofie",
  "signatureRequired" : true,
  "textures" : {
    "SKIN" : {
      "url" : "http://textures.minecraft.net/texture/c000d56909bcbb3542c65a2eb1b1c4810f907b277d041da2a1b16c894a96030c",
      "metadata" : {
        "model" : "slim"
      }
    },
    "CAPE" : {
      "url" : "http://textures.minecraft.net/texture/cb40a92e32b57fd732a00fc325e7afb00a7ca74936ad50d8e860152e482cfbde"
    }
  }
}```

[extremeheat]

That should be using mojangson

[rom1504]

https://github.com/PrismarineJS/node-mojangson

[rom1504]

Please remove this custom parsing and use https://github.com/PrismarineJS/node-mojangson instead

[Omena0]

Please fix the linting errors.

[fungoza]

bump, this thing still crashes bot without fix

[TheSharkyOfficial]

this should fix the crash now

[rom1504]

the .toString('utf8' and json parse is not necessary

[TheSharkyOfficial]

I just made and tested a new fix, because mojangson can't parse JSON, and also only for mojangson formatted skins .toString('utf8') is required because otherwise it would give hex data

[rom1504]

Can you add a test ?