feat(UFC Fight Pass): add activity#10673
Open
quanledg1108-spec wants to merge 1 commit intoPreMiD:mainfrom
Open
feat(UFC Fight Pass): add activity#10673quanledg1108-spec wants to merge 1 commit intoPreMiD:mainfrom
quanledg1108-spec wants to merge 1 commit intoPreMiD:mainfrom
Conversation
Signed-off-by: quanledg1108-spec <[email protected]>
|
seems like it is AI |
theusaf
requested changes
Apr 13, 2026
| "regExp": "^https?://([a-z0-9-]+\\.)*ufcfightpass\\.com/?", | ||
| "version": "1.0.0", | ||
| "logo": "https://i.imgur.com/hVg7eP2.jpg", | ||
| "thumbnail": "https://i.imgur.com/hVg7eP2.jpg", |
Contributor
There was a problem hiding this comment.
Image should be a landscape promotional image or screenshot. This image is too similar to logo
| clientId: "1492178685946499122", | ||
| }) | ||
|
|
||
| const IMAGE_KEY = "fightpassufc" |
Contributor
There was a problem hiding this comment.
This variable appears to be unused
|
|
||
| presence.on("UpdateData", async () => { | ||
| const now = Math.floor(Date.now() / 1000) | ||
| const video = document.querySelector("video") as HTMLVideoElement | null |
Contributor
There was a problem hiding this comment.
Use generics for querySelector
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| "id": "922677780074881045", | ||
| "name": "_y3n" | ||
| }, | ||
| "service": "UFC Fight Pass", |
| ], | ||
| "regExp": "^https?://([a-z0-9-]+\\.)*ufcfightpass\\.com/?", | ||
| "version": "1.0.0", | ||
| "logo": "https://i.imgur.com/hVg7eP2.jpg", |
| ], | ||
| "regExp": "^https?://([a-z0-9-]+\\.)*ufcfightpass\\.com/?", | ||
| "version": "1.0.0", | ||
| "logo": "https://i.imgur.com/hVg7eP2.jpg", |
| const title = document.title.trim() | ||
|
|
||
| const presenceData: PresenceData = { | ||
| largeImageKey: "https://i.imgur.com/hVg7eP2.jpg", |
There was a problem hiding this comment.
ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new PreMiD activity for UFC Fight Pass, allowing users to display their Discord Rich Presence while browsing and watching content on the platform.
The activity detects when a user is on the UFC Fight Pass homepage or watching a video and updates Discord accordingly. It includes support for:
Browsing state (homepage / browsing fights)
Watching state with dynamic video title display
Live, replay, and highlights detection
Pause detection with appropriate status update
countdown timestamp support for accurate session duration display
Consistent large image branding for UFC Fight Pass
The presence is designed to provide a smooth and accurate representation of user activity while maintaining performance and stability.
Acknowledgements
npm run lintScreenshots