Skip to content

feat(Cifra Club): add activity#10624

Open
guibsslol wants to merge 9 commits intoPreMiD:mainfrom
guibsslol:main
Open

feat(Cifra Club): add activity#10624
guibsslol wants to merge 9 commits intoPreMiD:mainfrom
guibsslol:main

Conversation

@guibsslol
Copy link
Copy Markdown

@guibsslol guibsslol commented Mar 30, 2026

Description

Add support for Cifra Club (cifraclub.com.br), the largest music teaching and chords website in Brazil.

Acknowledgements

Screenshots

Proof showing the creation/modification is working as expected Captura de tela 2026-03-30 135447 Captura de tela 2026-03-30 135541 Captura de tela 2026-03-30 135553 Captura de tela 2026-03-30 135803

Add metadata for Cifra Club service including author, description, and URLs.

Signed-off-by: Guilherme de Oliveira Monteiro <[email protected]>
Signed-off-by: Guilherme de Oliveira Monteiro <[email protected]>
Comment thread websites/C/Cifra Club/metadata.json Fixed
Copy link
Copy Markdown

@github-advanced-security github-advanced-security AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Signed-off-by: Guilherme de Oliveira Monteiro <[email protected]>
Signed-off-by: Guilherme de Oliveira Monteiro <[email protected]>
Comment thread websites/C/Cifra Club/presence.ts Fixed
Comment thread websites/C/Cifra Club/presence.ts Fixed
Comment thread websites/C/Cifra Club/presence.ts Fixed
Comment thread websites/C/Cifra Club/presence.ts Fixed
Signed-off-by: Guilherme de Oliveira Monteiro <[email protected]>
@theusaf theusaf requested a review from Bas950 April 1, 2026 16:24
@theusaf theusaf enabled auto-merge (squash) April 1, 2026 16:25
Copy link
Copy Markdown
Member

@Bas950 Bas950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theusaf low Q?

Comment thread websites/C/Cifra Club/metadata.json Outdated
Comment thread websites/C/Cifra Club/presence.ts Outdated
Updated the thumbnail image URL in metadata.json.

Signed-off-by: Guilherme de Oliveira Monteiro <[email protected]>
auto-merge was automatically disabled April 3, 2026 02:59

Head branch was pushed to by a user without write access

Signed-off-by: Guilherme de Oliveira Monteiro <[email protected]>
Refactored the presence update logic to enhance readability and maintainability, strictly following the PreMiD documentation. Removed auto-generated JSDoc tags (e.g., @see) and block comments inserted by a local VS Code extension.

Signed-off-by: Guilherme de Oliveira Monteiro <[email protected]>
@guibsslol guibsslol requested review from Bas950 and theusaf April 3, 2026 05:37
Copy link
Copy Markdown
Contributor

@theusaf theusaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's a bit low quality. The page looks like it has many other kinds of pages and features. Add support for those

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants