[arch] Ignore unused-result warning from debugger.cpp#3925
Closed
nvidia-jomiller wants to merge 1 commit intoPixarAnimationStudios:devfrom
Closed
[arch] Ignore unused-result warning from debugger.cpp#3925nvidia-jomiller wants to merge 1 commit intoPixarAnimationStudios:devfrom
nvidia-jomiller wants to merge 1 commit intoPixarAnimationStudios:devfrom
Conversation
nvidia-jomiller
changed the title
Collaborator
|
Filed as internal issue #USD-11718 (This is an automated message. See here for more information.) |
On gcc, or clang, write() from unistd.h will issue a warning if the result is not checked. This warning can not be suppressed using a void cast so the changes here will will explicity ignore the result via std::ignore.
nvidia-jomiller
force-pushed
the
dev-fix-warnings-arch-debugger
branch
from
85f1f32 to
b428d71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
On gcc, or clang,
write()from unistd.h will issue a warning if the result is not checked. Indebugger.cpp,write()is being called and the result is not being used (understandably, since the process is exited immediately after). This warning can not be suppressed using a void cast so the changes here will will explicitly ignore the result viastd::ignore.Fixes Issue(s)
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
[] I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)