Conversation
…pper version 3.3.2 to 3.3.4
Update all 15 POMs to Maven 4.1.0 model with new namespace and schema. Convert <modules> to <subprojects> in parent POMs and add root="true" attribute to the root POM. Migration done using mvnup tool with --model and --plugins flags. Avoided --infer strategy due to incorrect groupId removal from dependencies.
Rebase with Pi4J develop branch to stay uptated
|
A draft merge request for the Docker change is ready: Pi4J/pi4j-docker#5 |
| <mkdir dir="target/build"/> | ||
| <mkdir dir="target/build/native"/> | ||
| <mkdir dir="target" /> | ||
| <mkdir dir="target/classes" /> |
There was a problem hiding this comment.
Is is possible to avoid this kind of changes like extra spaces and removing newlines? That would simplify the review of the changes as it's not really clear now what is an actual change versus "cosmetic" change. Thanks!
There was a problem hiding this comment.
Agree, please use the same formatting. We can always decide on reformatting if necessary after such a PR is merged.
There was a problem hiding this comment.
Yes Sure, they are changes from mvnup apply command. @Kurocifer , please roll back then add only changes related to Maven Upgrade.
There was a problem hiding this comment.
Yes sure. As Fanjups says those were changes from teh mvnup apply command. I will roll that back and do back without the formatting.
…to the formatting performed by mvnup apply command
- Update all 15 POMs to Maven 4.1.0 model with new namespace and schema. - Convert <modules> to <subprojects> in parent POMs and add root="true" attribute to the root POM. - Avoid unecessary formatting introduced by the mvnup tool Migration done using mvnup tool with --model and --plugins flags. Avoided --infer strategy due to incorrect groupId removal from dependencies.
Merge with Pi4J develop branch to stay uptated
4 participants
Fix #562
Update Maven version from 3.9.4 to 4.0.0-rc-4 and wrapper version 3.3.2 to 3.3.4
Update POMs to use Maven 4.1.0 shcema and namespace
Final review to check if the 2 first tasks are enough before moving to pi4j docker