Skip to content

Add toggle of whether shield use ArmorMultiplier or not#2126

Merged
Coronia merged 13 commits intoPhobos-developers:developfrom
NetsuNegi:branch/shield_use_armormultiplier
Mar 18, 2026
Merged

Add toggle of whether shield use ArmorMultiplier or not#2126
Coronia merged 13 commits intoPhobos-developers:developfrom
NetsuNegi:branch/shield_use_armormultiplier

Conversation

@NetsuNegi
Copy link
Contributor

@NetsuNegi NetsuNegi commented Mar 2, 2026

In rulesmd.ini:

[CombatDamage]
ShieldApplyArmorMult=false            ; boolean

[SOMESHIELDTYPE]                      ; ShieldType name
ApplyArmorMult=                       ; boolean, default to [CombatDamage] -> ShieldApplyArmorMult

@NetsuNegi NetsuNegi added Needs testing ⚙️T1 T1 maintainer review is sufficient labels Mar 2, 2026
@github-actions
Copy link

github-actions bot commented Mar 2, 2026

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@phoboscn-bot
Copy link

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户:
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息:

https://www.phoboscn.top/t/topic/206/1

@Coronia
Copy link
Contributor

Coronia commented Mar 2, 2026

tag names should be ApplyArmorMult for consistency

@NetsuNegi NetsuNegi requested a review from TaranDahl March 2, 2026 05:15
Copy link
Contributor

@TaranDahl TaranDahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought of a new issue. If the shield doesn't fully absorb the damage, does the armor modifier take effect twice?

@NetsuNegi NetsuNegi force-pushed the branch/shield_use_armormultiplier branch from b409f7d to 5797da1 Compare March 16, 2026 23:59
@Coronia Coronia requested a review from TaranDahl March 17, 2026 07:34
@NetsuNegi NetsuNegi force-pushed the branch/shield_use_armormultiplier branch from c98a660 to 187aea2 Compare March 17, 2026 11:54
@TaranDahl TaranDahl added the Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions. label Mar 17, 2026
@Coronia Coronia merged commit 30b1002 into Phobos-developers:develop Mar 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙️T1 T1 maintainer review is sufficient Tested Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants