fix: always modify test file for skipping, never touch MANIFEST#15
Draft
Koan-Bot wants to merge 1 commit intoPerl-Toolchain-Gang:mainfrom
Draft
fix: always modify test file for skipping, never touch MANIFEST#15Koan-Bot wants to merge 1 commit intoPerl-Toolchain-Gang:mainfrom
Koan-Bot wants to merge 1 commit intoPerl-Toolchain-Gang:mainfrom
Conversation
Previously, set_skip_tests() handled tests in lib/, ext/, cpan/, and dist/ by removing them from the MANIFEST file. This caused t/porting/manifest.t to fail because the MANIFEST no longer listed files that were still present on disk. Now all tests — regardless of directory — are skipped by prepending the skip code directly to the test file, keeping the MANIFEST intact. The change_manifest() helper is preserved for backwards compatibility but is no longer called from set_skip_tests(). Fixes Perl-Toolchain-Gang#7 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When skipping tests in
lib/,ext/,cpan/, ordist/,set_skip_tests()previously removed those files from theMANIFEST. This causedt/porting/manifest.tto fail because the MANIFEST no longer matched the actual files on disk.Fixes #7
Changes
set_skip_tests()that divertedlib/ext/cpan/disttests tochange_manifest()change_manifest()is preserved but no longer calledt/smoker.tto verify the new behavior: all 5 test paths get skip code injected, MANIFEST stays unmodifiedTest plan
perl -Ilib t/smoker.t— all 82 tests passprove -Ilib t/*.t— all 1607 tests pass, no regressionsGenerated by Kōan /fix
Quality Report
Changes: 2 files changed, 19 insertions(+), 29 deletions(-)
Code scan: clean
Tests: skipped
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline