deps/softwarecontainer-dependencies.sh: Fix lxc and python3-lxc insta…#104
Open
alivenets wants to merge 3 commits intoPelagicore:masterfrom
Open
deps/softwarecontainer-dependencies.sh: Fix lxc and python3-lxc insta…#104alivenets wants to merge 3 commits intoPelagicore:masterfrom
alivenets wants to merge 3 commits intoPelagicore:masterfrom
Conversation
alivenets
force-pushed
the
fix-lxc-3-install-scripts
branch
from
8365af5 to
d5778cf
Compare
JEderonn
reviewed
Apr 15, 2020
JEderonn
reviewed
Apr 15, 2020
JEderonn
requested changes
Apr 15, 2020
JEderonn
left a comment
JEderonn
left a comment
There was a problem hiding this comment.
Please update the commit message with a better description. Thx.
Remove remaining LXC packages which are installed as a part of Ubuntu installation. Since LXC is installed manually, some remaining artifacts may break behavior of library and tools Signed-off-by: Alexander Livenets <alivenets@zoho.eu>
alivenets
force-pushed
the
fix-lxc-3-install-scripts
branch
2 times, most recently
from
8a57543 to
6871bdf
Compare
python3-lxc Ubuntu package depends on LXC packages, therefore LXC of conflicting version will be installed. This commits fixes installation of python-lxc by installing it from source. Signed-off-by: Alexander Livenets <alivenets@zoho.eu>
alivenets
force-pushed
the
fix-lxc-3-install-scripts
branch
from
6871bdf to
7600b91
Compare
Looks better, but 7600b91 still lacks a "why" seccomp and apparmor are enabled. |
alivenets
force-pushed
the
fix-lxc-3-install-scripts
branch
from
7600b91 to
5c2b093
Compare
JEderonn
approved these changes
Apr 21, 2020
JEderonn
left a comment
JEderonn
left a comment
There was a problem hiding this comment.
Approved, looks good but have not tested the scripts
Collaborator
|
Fix title in 5c2b093 though, please. |
Add `--enable-apparmor` and `--enable-seccomp` flags at LXC configuration stage AppArmor is required to allow to apply additional MAC restrictions to container described in AppArmor profile. seccomp is required to apply additional restrictions on system calls from container using seccomp syscall blacklist and whitelist. Signed-off-by: Alexander Livenets <alivenets@zoho.eu>
alivenets
force-pushed
the
fix-lxc-3-install-scripts
branch
from
5c2b093 to
b3af3b6
Compare
pookimon
approved these changes
Apr 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…llation
Remove unneeded LXC packages
Install python3-lxc from source
Signed-off-by: Alexander Livenets alivenets@zoho.eu