added method for restarting the phase accumulator#475
Open
phjanderson wants to merge 1 commit intoPaulStoffregen:masterfrom
Open
added method for restarting the phase accumulator#475phjanderson wants to merge 1 commit intoPaulStoffregen:masterfrom
phjanderson wants to merge 1 commit intoPaulStoffregen:masterfrom
Conversation
Contributor
|
I am completely butting my nose in here...but I support the idea that this is a worthy functionality to include. Oscillator reset is absolutely a thing. It's not super-common, but those synths that do it are very distinctive and iconic. Moog Taurus bass pedals being probably the most iconic. So, yeah, I have not tried this particular implementation, but the motivation is good. It's a worthy functionality for an oscillator to have. Chip |
|
This is an absolutely necessary function, for example to start modulating the frequency or amplitude with an LFO with a fixed phase angle at every "note on". I've been using it for years. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a method restart() to AudioSynthWaveform and AudioSynthWaveformModulated to reset the phase_accumulator to 0. This allows the phase of multiple oscillators in a synthesizer to be synchronized upon note on.